Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(evm, utils): Move utility error traits to utils #5286

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Jul 4, 2023

Tackles one of the items in #4928. The error file on the evm crate was a bit generic and useful, so it was moved out of it and into the utils crate.

@Evalir Evalir requested a review from mattsse July 4, 2023 02:15
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@@ -9,6 +9,7 @@ keywords = ["ethereum", "web3", "evm"]

[dependencies]
foundry-abi = { path = "../abi" }
foundry-utils = { path = "../utils" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah!

@mattsse mattsse merged commit bf56869 into master Jul 4, 2023
@mattsse mattsse deleted the evalir/move-decode-utils branch July 4, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants