Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forge): add selectors list subcommand #6075

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

schroyar
Copy link
Contributor

Motivation

Lists functions, events and errors signatures + selectors of an individual contract or all contracts in the workspace

Closes #6038

Solution

  • add List to the SelectorsSubcommands enum on inspector.rs and implement the logic, using comfy_table to print the results

Example output:

forge selectors ls Dummy

image

@schroyar schroyar changed the title Forge selectors ls feat(forge): add selectors list subcommand Oct 21, 2023
@schroyar schroyar mentioned this pull request Oct 24, 2023
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I made some simplifications now that we moved to alloy types

pending @Evalir

@mattsse mattsse requested a review from Evalir November 1, 2023 18:10
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! will be useful for a lot of people. Love the simplifications @mattsse

@Evalir Evalir merged commit c602db6 into foundry-rs:master Nov 1, 2023
16 checks passed
@holic
Copy link

holic commented Nov 1, 2023

thanks all!

@seanmc9
Copy link

seanmc9 commented Nov 23, 2023

Just want to say thank you for this!! This is so helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forge selectors list
5 participants