Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: function returns formatting #6086

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Oct 23, 2023

closes #4080

this adds a hardcoded check for function pointer return values, because they are formatting using the built-in formatter which means indents are applied twice.

maybe the better fix would be to check for this when actually formatting the argument chunk, but it looks like this issue is only limited to function return arguments.

@mattsse
Copy link
Member Author

mattsse commented Oct 25, 2023

friendly bump @Evalir @rkrasiuk

Copy link
Collaborator

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix lgtm

@mattsse mattsse merged commit 3fe2392 into foundry-rs:master Oct 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forge fmt incorrectly handles multi-line function pointer types in returns definitions
2 participants