-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use foundry-cheatcodes
implementations
#6131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lfg!!!
one suggestion, otherwise lgtm, pending tests
Evalir
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much better—I think once tests pass we're good to go!
🔥 |
This was referenced Nov 7, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unblocks all other cheatcode PRs.
Follow-up to #5998, #6128.
This PR deprecates
foundry-abi
, which will require another follow up to remove completely since it's still used for some trace and log decoding.Solution
Replace old Ethers cheatcodes with new Alloy cheatcodes.
Breaking changes
parse*
andenv*
:bool
values are now parsed as strictlytrue|false
instead of[tT]rue|[fF]alse
bytes32
values are not padded anymore when encountering less than 32 hex bytes, e.g.0x0102
won't be padded to0x0102000000000000000000000000000000000000000000000000000000000000
and instead fail parsing with "invalid string length"ffff
parses when it should fail because of missing0x
prefix. This is tracked here: [Bug]Signed::from_str
should have the same behavior asUint
alloy-rs/core#387CheatcodeError(string)
, instead of either the default Solidity revert (Error(string)
) or an arbitrary signature (CheatCodeError
)