Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): properly parse functions in their usual form #6136

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Oct 27, 2023

Closes #6135

Alloy's Function only parses functions without their return arguments and without the function prefix. We can use AbiItem::parse to parse them as human-readable abi strings and get a Function in return.

@Evalir Evalir requested a review from mattsse October 27, 2023 08:17
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a few sanity tests here

@Evalir
Copy link
Member Author

Evalir commented Oct 27, 2023

Added a test @mattsse — albeit we'll need a new feature in alloy to parse full function signatures. Right now we can only parse either stripped functions or human-readable ABI functions which don't support visibility modifiers. cc @DaniPopes

ref alloy-rs/core#389

@mattsse mattsse merged commit 57ffd4a into master Oct 27, 2023
16 checks passed
@mattsse mattsse deleted the evalir/fix-cast-send-sig branch October 27, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cast fails to parse signature after update
2 participants