fix: gas report threshold #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
approved these changes
Oct 28, 2023
| // Note: the diff score can be inaccurate for small contracts so we're using | ||
| // a relatively high threshold here to avoid filtering out too many | ||
| // contracts. | ||
| if score < 0.85 { |
There was a problem hiding this comment.
super small nit, but maybe we can lift this to a constant and document it?
There was a problem hiding this comment.
I think that's fine here, I also think this entire logic deserves another look because we only do this to filter out candidates for decoding matches, the better approach would be to just get all function selectors
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6019
ref #6129
refactors the gas reporter slightly.
also increases the diff matching used for matching contract codes
cc @mds1