Add support for events and errors in forge selectors upload
#6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Nov 3, 2023
crates/common/src/selectors.rs
Outdated
Comment on lines
308
to
310
| func.signature().split(':').next().unwrap_or("").to_string() | ||
| }) | ||
| .chain(abi.abi.errors().map(|error| error.signature())) |
There was a problem hiding this comment.
I don't think this split is needed anymore, right @Evalir ?
There was a problem hiding this comment.
Yep I think it might not be needed anymore—now the actual abi comes from alloy
Evalir
approved these changes
Nov 3, 2023
crates/common/src/selectors.rs
Outdated
Comment on lines
308
to
310
| func.signature().split(':').next().unwrap_or("").to_string() | ||
| }) | ||
| .chain(abi.abi.errors().map(|error| error.signature())) |
There was a problem hiding this comment.
Yep I think it might not be needed anymore—now the actual abi comes from alloy
|
Thanks a lot for the effort, guys! This is really important for us, smart contract developers wanting to adopt custom errors and wanting to display them nicely in the front-end of applications. :-) |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently
forge selectors uploadcommand does not upload errors and events.Closes #5924, #5241 and maybe #5012
Solution
Upload errors and events also. openchain.xyz API does not have a separate field for errors, so functions and errors are uploaded together. Same solution is used by openchain.xyz "Import" page, so it seems to be considered a correct way which does not pollute the database.