Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anvil): anvil_metadata #6240

Merged
merged 4 commits into from
Nov 7, 2023
Merged

feat(anvil): anvil_metadata #6240

merged 4 commits into from
Nov 7, 2023

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Nov 7, 2023

Closes #6221. ref @antazoey

Adds the anvil_metadata method, which is the anvil equivalent of hardhat_metadata.

The instance ID is random and changes on every node boot, or when anvil_reset is called.

@Evalir Evalir requested a review from mattsse November 7, 2023 15:04
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, suggesting alias

Comment on lines 494 to 495
#[cfg_attr(feature = "serde", serde(rename = "anvil_metadata", with = "empty_params"))]
AnvilMetadata(()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add hardhat_metdata alias?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ya, sounds good

@mattsse mattsse merged commit 3432386 into master Nov 7, 2023
16 checks passed
@mattsse mattsse deleted the evalir/anvil-metadata branch November 7, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer anvil_metadata RPC
3 participants