Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up remaining ethers usage #6254

Merged
merged 30 commits into from
Nov 10, 2023
Merged

chore: clean up remaining ethers usage #6254

merged 30 commits into from
Nov 10, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 8, 2023 •
edited
Loading

Fixes #6252

@DaniPopes
Copy link
Member Author

Fixes #6252 (fixed in Alloy JsonAbi::to_sol):

image

DaniPopes
DaniPopes commented Nov 8, 2023
View reviewed changes
crates/config/src/cache.rs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-️ -> -

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@DaniPopes DaniPopes marked this pull request as ready for review November 10, 2023 18:02
mattsse
mattsse approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monster PR,
luckily most if it are rename/import changes,
actual changes lgtm
one question re default solc pragma

crates/cast/bin/cmd/interface.rs
@@ -19,7 +20,7 @@ pub struct InterfaceArgs {
name: Option<String>,

/// Solidity pragma version.
#[clap(long, short, default_value = "^0.8.10", value_name = "VERSION")]
#[clap(long, short, default_value = "^0.8.4", value_name = "VERSION")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom errors were introduced in 0.8.4

crates/config/src/cache.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@DaniPopes DaniPopes merged commit 74b641f into master Nov 10, 2023
20 checks passed
@DaniPopes DaniPopes deleted the dani/cleanup-ethers branch November 10, 2023 19:23
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cast interface does not include payable address modifier
2 participants
@DaniPopes @mattsse