Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cheatcodes): mark rpc + eth_getLogs cheatcodes as script safe #6255

Merged
merged 3 commits into from
Nov 8, 2023
Merged

feat(cheatcodes): mark rpc + eth_getLogs cheatcodes as script safe #6255

merged 3 commits into from
Nov 8, 2023

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Nov 8, 2023

No description provided.

@Evalir Evalir requested review from DaniPopes and mds1 November 8, 2023 18:46
mattsse
mattsse reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does Safe/Unsafe mean hear?

@Evalir Evalir changed the title feat(cheatcodes): mark *Fork + rpc + eth_getLogs cheatcodes as safe feat(cheatcodes): mark rpc + eth_getLogs cheatcodes as script safe Nov 8, 2023
@Evalir
Copy link
Member Author

Evalir commented Nov 8, 2023

Safe/Unsafe refer to script safety or unsafety—cheatcodes unsafe to use in scripts are marked as such

mattsse
mattsse approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @DaniPopes

@mds1
Copy link
Collaborator

mds1 commented Nov 8, 2023 •
edited
Loading

Certain fork cheats like createSelectFork and selectFork can also be marked as safe even though they're currently unsafe (but some like rollFork or transact should stay unsafe). I'm ok doing this here or in a follow up PR—more broadly we may want to just take a pass at the safety status and make sure everything looks good, in which case a follow up PR might be a better fit

@DaniPopes DaniPopes merged commit a5040df into master Nov 8, 2023
19 checks passed
@DaniPopes DaniPopes deleted the evalir/make-fork-safe branch November 8, 2023 21:50
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@mds1 mds1 Awaiting requested review from mds1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Evalir @mds1 @mattsse @DaniPopes