Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve error decoding and value formatting #6286

Merged
merged 3 commits into from
Nov 11, 2023
Merged

feat: improve error decoding and value formatting #6286

merged 3 commits into from
Nov 11, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 11, 2023 •
edited
Loading

Motivation

  • use Debug for strings
  • add exponential notation hint to signed integers too
  • use "assertion failed" instead of "<no data>" when assertions fail in fuzz tests

Solution

mattsse
mattsse approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Evalir
Evalir approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@DaniPopes DaniPopes merged commit c489e3f into master Nov 11, 2023
20 checks passed
@DaniPopes DaniPopes deleted the dani/better-fmt branch November 11, 2023 16:10
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @mattsse @Evalir