Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cheatcodes): add computeCreateAddress cheatcodes #6296

Merged
merged 3 commits into from
Nov 14, 2023
Merged

feat(cheatcodes): add computeCreateAddress cheatcodes #6296

merged 3 commits into from
Nov 14, 2023

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Nov 13, 2023 •
edited by DaniPopes
Loading

Motivation

Closes #6270
add computeCreateAddress and computeCreate2Address to cheatcodes.

Solution

As suggested in comment, I transformed these code in forge-std to cheatcodes.

I am very new to rust, please correct me if any thing is wrong.

mattsse
mattsse requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,

sorry you had to port these from solidity -.-

crates/cheatcodes/src/utils.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/utils.rs Outdated Show resolved Hide resolved
@qiweiii qiweiii requested a review from Evalir as a code owner November 14, 2023 11:46
DaniPopes
DaniPopes approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit c8954d8 into foundry-rs:master Nov 14, 2023
19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse requested changes

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature(cheatcode): vm.predictContractAddr(); pre-determine next deployed addresses
3 participants
@qiweiii @mattsse @DaniPopes