Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable anvil-core serde feature by default in tests #6313

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Nov 14, 2023

just making the optional dep non optional in dev-deps isn't sufficient

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting where did this come up?

@mattsse
Copy link
Member Author

mattsse commented Nov 14, 2023

@anikaraghu flagged this

we only run tests on the workspace level not individual crates so we never encountered this because then serde feature is enabled

@mattsse mattsse merged commit 106889c into foundry-rs:master Nov 14, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants