chore(deps): bump axum to 0.6 #6321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
changed the title
mattsse
approved these changes
Nov 15, 2023
crates/anvil/server/src/handler.rs
Outdated
| /// Handles incoming JSON-RPC Request | ||
| pub async fn handle<Handler: RpcHandler>( | ||
| /// Handles incoming JSON-RPC Request. | ||
| // NOTE: `State` must come first because the `request` extractor consumes the request body. |
There was a problem hiding this comment.
ah I remember struggling to make this work
very nice
There was a problem hiding this comment.
Yeah it took me an hour to figure it out :D
That is literally the only thing that stopped it from compiling, the error being as generic as possible (fn(..)->.. doesn't implement Handler) and the debug_handler macro not working with generics didn't help
DaniPopes
force-pushed
the
dani/bump-hyper
branch
from
28e14c6
to
f8f5977
Compare
This was referenced Nov 17, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And
fdlimitThe only breaking change is that only one extractor can consume the response body, so the handler has to come before the response in the HTTP handler function.
Additionally, the Axum changelog recommends changing
ExtensiontoState.cc @mattsse