chore(script): remove PUSH0 warnings for superchain testnets
#6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Nov 16, 2023
|
I think Zora and PGN both have testnets that now would also support Shanghai for the same reason |
mattsse
approved these changes
Nov 16, 2023
Comment on lines
72
to
+78
| static SHANGHAI_ENABLED_CHAINS: &[Chain] = &[ | ||
| // Ethereum Mainnet | ||
| Chain::Mainnet, | ||
| // Goerli | ||
| Chain::Goerli, | ||
| // Sepolia | ||
| Chain::Sepolia, | ||
| Chain::OptimismGoerli, | ||
| Chain::OptimismSepolia, | ||
| Chain::BaseGoerli, |
There was a problem hiding this comment.
we should move this to alloy-chains
|
@mds1 yep, but they aren't on alloy-rs/chains yet—let's add them and move these to the new repo in a follow up |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Per the new canyon hard fork, push0 is supported on all superchain testnet networks.
Solution
Remove the warning
(Eventually we should have a better way to add/remove these warnings rather than a static list, but we can think about this later)