chore: bump default memory limit to 128MiB #6338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Nov 17, 2023
DaniPopes
force-pushed
the
dani/memory-limit
branch
from
ef4cdcf
to
8ef141a
Compare
Evalir
approved these changes
Nov 17, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since #6281, Revm treats
memory_limitas an upper limit of an entire execution (e.g.executor.call()from start to end), rather than per each EVM call frame. I believe this new approach makes more sense, and since we've seen some tests fail in #6281 we can bump our defaults to accomodate these changes.Solution