Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anvil): anvil_metadata return types #6360

Merged
merged 1 commit into from
Nov 19, 2023
Merged

fix(anvil): anvil_metadata return types #6360

merged 1 commit into from
Nov 19, 2023

Conversation

DaniPopes
Copy link
Member

Motivation

Fixes #6335
Also made chain_id a u64 as it should be

Solution

@DaniPopes DaniPopes marked this pull request as ready for review November 19, 2023 17:06
mattsse
mattsse approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes DaniPopes merged commit 3e962e2 into master Nov 19, 2023
18 of 19 checks passed
@DaniPopes DaniPopes deleted the dani/anvil-metadata branch November 19, 2023 18:02
@RedaOps RedaOps mentioned this pull request Nov 20, 2023
Merged
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

anvil_metadata returning hex instead of ints
2 participants
@DaniPopes @mattsse