-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cheatcodes): coerce root values #6441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
not sure why, can't think of anything why this should not be the case
is this on top of #6439 ?
Initial implementation for reference: foundry/crates/evm/src/executor/inspector/cheatcodes/ext.rs Lines 327 to 376 in ee5d02c
root key always encodes as bytes, i don't believe this worked before either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation
Fixes #6437
Don't know why we wouldn't coerce root values too, cc @odyslam as initial implementer
Solution