Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forge create to use config values for verify preflight check #6467

Merged

Conversation

dghelm
Copy link
Contributor

@dghelm dghelm commented Nov 30, 2023

Motivation

As described in #6466 , forge create --verify could not be called using foundry.toml

Solution

Update the etherscan API key from the Config in the information that is checked in the preflight. This means if no ETHERSCAN_API_KEY is set as an env var or flag, the config files will be used as opposed to failing the preflight check.

Note

If a test is needed here, I might need my handheld. Very new to Rust, so also unsure if it's okay here to make verify mutable.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, ty!

@mattsse mattsse merged commit 94b5d31 into foundry-rs:master Nov 30, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants