fix: forge create to use config values for verify preflight check #6467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As described in #6466 ,
forge create --verify
could not be called usingfoundry.toml
Solution
Update the etherscan API key from the Config in the information that is checked in the preflight. This means if no
ETHERSCAN_API_KEY
is set as an env var or flag, the config files will be used as opposed to failing the preflight check.Note
If a test is needed here, I might need my handheld. Very new to Rust, so also unsure if it's okay here to make
verify
mutable.