Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove fork db snapshot #6486

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Dec 1, 2023

this fixes an inconsistency highlited by #6463

fork db snapshots were always kept on revert, but state snapshots were always removed, the intended behaviour (ganache, hardhat compat) is to remove a snapshot on evm_revert

also related

#6366

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im fine with removing this as it's causing a lot of trouble for anvil users, but this will break existing test suites which now depend on this behavior, aave's included.

@mattsse
Copy link
Member Author

mattsse commented Dec 1, 2023

but this will break existing test suites which now depend on this behavior, aave's included.

forge is unaffected by this.
this merely fixes a bug in anvil

FYI @naps62 there's now a RevertAction parameter this will be useful when integrating the optional bool param to evm_revert request

@mattsse mattsse merged commit 3326883 into foundry-rs:master Dec 1, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants