fix(forge): pre-emptively create lib dir if it doesn't exist for updating submodules

[Evalir]

Motivation

Closes #6519

Solution

Check if there are any submodules at all in the repo, and only update if so.

[mattsse]

the failing test look related

the issue here is that we want to update a folder that does not exist.

I think we should instead only perform the update if the folder already exists.

[Evalir]

Yeah so what's happening here is an edge case for prb-proxy: The reason why we wanna be able to run submodule update on an empty lib file is that we could have missing deps that might have been removed (manually), and we need to reinstall them through a .gitmodules. prob-proxy doesn't have one, so it will just not install any deps at all.

I think the fix here is to check if the .gitmodules file exists, and if not, skip the submodule update. If it exists, even if the dir is empty we wanna run the update as we could have missing deps.

[mattsse]

can we add a sanity test for this:

empty project + call forge install

[PaulRBerg]

Thanks for the quick turnaround 🙏

[PaulRBerg]

There's still a problem left, though .. running forge install will add the following setting in foundry.toml:

libs = ["node_modules", "lib"]

Would it be possible to have Forge not do this?

[sambacha]

Yeah so what's happening here is an edge case for prb-proxy: The reason why we wanna be able to run submodule update on an empty lib file is that we could have missing deps that might have been removed (manually), and we need to reinstall them through a .gitmodules. prob-proxy doesn't have one, so it will just not install any deps at all.

I think the fix here is to check if the .gitmodules file exists, and if not, skip the submodule update. If it exists, even if the dir is empty we wanna run the update as we could have missing deps.

please do not do this, some people may use git submodules for non-foundry reasons.

This issue also closes my issue #2649