feat: add additional snapshot cheatcodes #6548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/add-snapshot-cheatcodes
branch
from
9e3bd2b to
36bd3c1
Compare
Evalir
approved these changes
Dec 10, 2023
DaniPopes
approved these changes
Dec 11, 2023
2 tasks
|
Awesome thanks a million! |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #6411
since we're persisting snapshots on
revertTowe have unbounded memory growth.We want to keep them for convenience, so we need additional cheatcodes to handle cleanup:
revertTo, not sure what would be the best UX, but we could add an overloaded function as well (id, bool))FYI @maa105 @karlb