Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cheatcodes): getBlockNumber and getBlockTimestamp #6630

Merged
merged 8 commits into from
Dec 21, 2023
Merged

feat(cheatcodes): getBlockNumber and getBlockTimestamp #6630

merged 8 commits into from
Dec 21, 2023

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Dec 20, 2023

Motivation

Closes #6180

@Evalir @DaniPopes
Update testdata/cheats/GetBlockTimestamp.t.sol
d5fe942 
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
mattsse
mattsse approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, this acts like a blockbox so the compiler doesn't inline it.

can we add a note to the docs about this?

DaniPopes
DaniPopes requested changes Dec 20, 2023
View reviewed changes
crates/cheatcodes/spec/src/vm.rs Outdated Show resolved Hide resolved
@Evalir Evalir merged commit cb6c44d into master Dec 21, 2023
19 checks passed
@Evalir Evalir deleted the evalir/timestamp-height-cheatcodes branch December 21, 2023 03:46
@DaniPopes DaniPopes mentioned this pull request Dec 21, 2023
Merged
@Evalir Evalir mentioned this pull request Jan 3, 2024
Closed
2 tasks
@ZeroEkkusu
Copy link
Contributor

ZeroEkkusu commented Mar 12, 2024 •
edited
Loading

Just a heads up that this is not documented in a visible place, yet can result in false passing tests.
It needs to be documented in warp, skip, rewind, and any other places where the block timestamp/number is changed.

image

This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes requested changes

@mds1 mds1 mds1 approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

block.timestamp bugs when using skip
5 participants
@Evalir @ZeroEkkusu @mds1 @mattsse @DaniPopes