feat: add unsafe-password support to cast wallet import #6671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
--unsafe-password
option to thecast wallet import
cli.Motivation
Our test suite uses the foundry docker image to start
anvil
and then executescast
commands using that docker image. As test cases have been built, we found that it would be beneficial to be able to import an account usingcast wallet import
, but it requires a password prompt making this difficult in our test environment while other commands such ascast wallet new
do not have this limitation.Solution
An option,
--unsafe-password
, was added to thecast wallet import
command to support bypassing the password prompt by passing the password in the cli. This solution is similar to thecast wallet new
command along with othercast
commands that use a keystore.Note: this new option does not currently include a test case. There are no existing test cases for
cast wallet import
to mirror. I have a test case prepped, but subsequent test runs with it will fail due to the account name's keystore already existing unlikecast wallet new
which will have a unique keystore filename on each run.