Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(chisel): remove 'errored', make session_source non-optional #6748

Merged
merged 1 commit into from
Jan 16, 2024
Merged

refactor(chisel): remove 'errored', make session_source non-optional #6748

merged 1 commit into from
Jan 16, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jan 9, 2024 •
edited
Loading

Motivation

This is never None and errored is based on the result

Review without whitespace

Solution

@DaniPopes DaniPopes force-pushed the dani/refactor-chisel branch from 6256a06 to fd7ed00 Compare January 16, 2024 16:46
mattsse
mattsse approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makese sense, lgtm

this is a lot cleaner, ty boss

@mattsse mattsse added the C-chisel Command: chisel label Jan 16, 2024
@DaniPopes DaniPopes merged commit f8dfd2c into master Jan 16, 2024
19 of 20 checks passed
@DaniPopes DaniPopes deleted the dani/refactor-chisel branch January 16, 2024 17:38
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
C-chisel Command: chisel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse