chore: new retryable ratelimit error #6751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Jan 9, 2024
crates/common/src/provider/retry.rs
Outdated
| @@ -84,6 +84,10 @@ fn should_retry_json_rpc_error(error: &ErrorPayload) -> bool { | |||
| return true | |||
| } | |||
|
|
|||
| if *code == -32005 && message.contains("archive request rate exceeded") { | |||
There was a problem hiding this comment.
actually, this is weird. it should have been caught by this already:
https://github.com/foundry-rs/foundry/blob/master/crates/common/src/provider/retry.rs#L77-L78
which makes me think that retryprovider is not properly configured or it's not properly handling the errors:
https://github.com/foundry-rs/foundry/blob/master/crates/common/src/provider/retry.rs#L31-L44
mattsse
force-pushed
the
matt/new-retry-error
branch
from
15b26de to
bf1aa7b
Compare
RPate97
pushed a commit
to RPate97/foundry
that referenced
this pull request
Jan 12, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new retry error unlocked
https://github.com/foundry-rs/foundry/actions/runs/7466523925/job/20318067711?pr=6750