Mark envOr functions as view #6757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikaraghu
force-pushed
the
anika/envor-view
branch
from
4ff94d1
to
d55c90e
Compare
anikaraghu
force-pushed
the
anika/envor-view
branch
from
d55c90e
to
780ce3b
Compare
anikaraghu
commented
Jan 11, 2024
| @@ -1060,15 +1060,14 @@ impl Backend { | |||
| env.block.basefee = base; | |||
| } | |||
|
|
|||
| let gas_price = | |||
| gas_price.map(|g| g).or(max_fee_per_gas.map(|g| g)).unwrap_or_else(|| self.gas_price()); | |||
| let gas_price = gas_price.or(max_fee_per_gas).unwrap_or_else(|| self.gas_price()); | |||
There was a problem hiding this comment.
clippy was complaining about this
anikaraghu
requested review from
Evalir,
mattsse and
DaniPopes
as code owners
mattsse
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
lgtm!
this doesn't conflict with forge-std, right @DaniPopes @mds1 ? so we can merge this independently?
|
@mattsse correct, once this is merged we just need to run the forge-std python script to update forge-std, then I can put out a new release |
This was referenced Jan 11, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I tried using vm.envOr in a view function and noticed it wasn't marked as view, so this led to errors. Checked with foundry devs and looks like this was just an oversight.
Solution
Add
viewmodifier toenvOrfunctions