Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ForkIds unique #6765

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jan 11, 2024

closes #6759

this removes the URL hack and instead makes forks unique on the id level while also reusing existing backends.

This means forkIds are always unique but they can reuse existing backends

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 06fc9ea into foundry-rs:master Jan 11, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createFork for same block number multiple times adds an extra / for every call
3 participants