Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use provided name for inspect pretty #6817

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: use provided name for inspect pretty #6817

merged 1 commit into from
Jan 16, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jan 16, 2024

Closes #6816

formatted abi needs a name

@mattsse mattsse mentioned this pull request Jan 16, 2024
Closed
2 tasks
DaniPopes
DaniPopes approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

foundry/crates/forge/bin/cmd/inspect.rs

Line 214 in c2de140

let source = foundry_utils::abi::abi_to_solidity(&abi_json, "")?;

@mattsse mattsse merged commit 78ed707 into foundry-rs:master Jan 16, 2024
19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forge inspect <sc> abi --pretty raises error
2 participants
@mattsse @DaniPopes