chore: use EvmVersion::Cancun #6906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is anyone using this in foundry.toml? |
|
https://github.com/hrkrshnn/tstore-template perhaps we should keep the value for a bit? |
mattsse
force-pushed
the
matt/support-cancun-evm-version
branch
from
bc16a37 to
5b6618e
Compare
|
We can keep a deprecation warning for a bit and if it's true just set evmversion to cancun |
mattsse
force-pushed
the
matt/support-cancun-evm-version
branch
from
5b6618e to
5470fea
Compare
|
good idea, rolled it back and added deprecation entry |
DaniPopes
reviewed
Jan 26, 2024
crates/config/src/lib.rs
Outdated
| /// Deprecated keys and their replacements. | ||
| /// | ||
| /// See [Warning::DeprecatedKey] | ||
| pub static DEPRECATIONS: Lazy<HashMap<String, String>> = |
There was a problem hiding this comment.
Since there aren't / there won't be many, this should just be a &[(&str, &str)] with a linear search where it's used. Same for STANDALONE_FALLBACK_SECTIONS
There was a problem hiding this comment.
right, unrelated to this pr but might as well just fix that here
DaniPopes
requested changes
Jan 26, 2024
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
DaniPopes
approved these changes
Jan 26, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this deprecates the tmp cancun config value and supports new
EvmVersion::Cancunblocked by svm 0.8.24 release