feat: cast mktx
#7056
feat: cast mktx
#7056
Conversation
| let signature = provider.sign_transaction(&tx, from).await?; | ||
| let signed_tx = tx.rlp_signed(&signature); |
There was a problem hiding this comment.
Since we're actually signing the transaction, this probably should be behind cast wallet similar to the existing cast wallet sign. What do you think about also renaming this to cast wallet sign-tx to make it more explicit? I don't think cast needs to be backwards compatible with seth anymore.
I could imagine a separate cast mktx command that returns a populated (optionally serialized) transaction, without signing it
There was a problem hiding this comment.
I went back and forth a few times on this and initially implemented this as cast wallet sign-tx, but ultimately decided cast mktx is better. The cast wallet commands don't use TxBuilder, don't use an RPC connection, and therefore have no way of filling a transaction with gas info, nonce, ENS resolution, etc. Having it as cast mktx allows it to be as close to cast send as possible, with the difference being it prints the encoded transaction instead of broadcasting it. You get everything provided by TxBuilder if you need it, but can still specify all the options manually if you have no connection to an RPC endpoint.
There was a problem hiding this comment.
I suppose it can be renamed to something like cast sign-tx, but since the behavior is identical to seth mktx (which builds and signs transactions) I went with cast mktx.
There was a problem hiding this comment.
I think a good general principle is to implement the UX that's best for the user, even if it's more work because cast wallet commands don't yet have TxBuilder or RPC connections. Most foundry users haven't used (or heard of) dapptools and seth is no longer maintained, so we should use the best naming/UX regardless of what seth did.
However, IMO the cast UX is already messy and needs breaking change cleanup, so I won't block this PR on trying to keep cast UX clean or changing command names. Just sharing my thoughts, and will defer to you and other foundry maintainers from here :)
There was a problem hiding this comment.
Yeah, I agree. I wasn't sure what the best place for this was either. Because of how close its logic is to cast send, I put it adjacent to where that is. I can rename/move it wherever (though moving it under cast wallet will require a few more changes like importing TxBuilder and the utility functions in common with cast send).
|
I've added some tests. |
Motivation
Similar to
seth mktxfrom dapptools, there should be a command to build and sign transactions without broadcasting them. Ideally it should be possible to do this on an offline machine.Solution
cast mktxis the same ascast sendexcept it prints out a raw hex encoding of the signed transaction instead of broadcasting. This output can then be published withcast publish. It also works without an RPC (for example on an air-gapped machine) if all the required options are set.I can also update the Foundry book if merged.
Closes #1273