Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate crate for wallets logic #7086

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Feb 12, 2024

Motivation

Extracts wallet logic to separate crate to make it more resusable. After that it will be possible to add foundry-wallets as a dependency of foundry-cheatcode to support unlocking and using wallets directly from cheatcodes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

this unblocks us from turning this into an actually usable crate eventually

I think we can push more code from the wallet command impl to the wallet crate

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this does add clap and other dependencies earlier. This might not matter much , and I don't see a way around this without duplicating structs.

@mattsse
Copy link
Member

mattsse commented Feb 12, 2024

yeah, I only see this as an intermediary issue, because I think we want this crate to be more like a library and then move the clap types back to the cli crate.

but this is a less invasive first step in that direction

@mattsse mattsse merged commit b783a50 into foundry-rs:master Feb 12, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants