Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forge): fix debugger buffer-write highlight else-if fallthrough #7126

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix(forge): fix debugger buffer-write highlight else-if fallthrough #7126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/debugger/src/tui/draw.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,12 +518,11 @@ impl DebuggerContext<'_> {
let stack_len = step.stack.len();
if stack_len > 0 {
if let Some(accesses) = get_buffer_accesses(op, &step.stack) {
if let Some(read_access) = accesses.read {
if read_access.0 == self.active_buffer {
offset = Some(read_access.1.offset);
size = Some(read_access.1.size);
color = Some(Color::Cyan);
}
if accesses.read.as_ref().is_some_and(|a| a.0 == self.active_buffer) {
let read_access = accesses.read.unwrap();
offset = Some(read_access.1.offset);
size = Some(read_access.1.size);
color = Some(Color::Cyan);
} else if let Some(write_access) = accesses.write {
// TODO: with MCOPY, it will be possible to both read from and write to the
// memory buffer with the same opcode
Expand Down
Loading