[cast] Fix cast wallet verify #7215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses #7214 |
Evalir
requested changes
Feb 22, 2024
crates/cast/bin/cmd/wallet/mod.rs
Outdated
| println!("Validation succeeded. Address {address} signed this message."); | ||
| } else { | ||
| println!("Validation failed. Address {address} did not sign this message."); | ||
| match signature.verify(Self::hex_str_to_bytes(&message)?, address.to_ethers()) { |
There was a problem hiding this comment.
We should not be using the old ethers type here. We should actually use recover_address_from_msg from the alloy Signature type.
Evalir
approved these changes
Feb 22, 2024
|
@DaniPopes yep was just gonna push one |
DaniPopes
approved these changes
Feb 23, 2024
zeroXbrock
pushed a commit
to flashbots/suavex-foundry
that referenced
this pull request
Apr 2, 2024
* Fix cast wallet verify * fmt * fix(cast): use recover_address_from_msg * chore: add test, abstract addr recovery for testing --------- Co-authored-by: Enrique Ortiz <hi@enriqueortiz.dev>
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#7088 broke
cast wallet verify. The following worked previously and no longer works:Error:
Solution
This PR reverts a subset of the PR above which fixes the issue. Happy to take suggestions on alternative paths. Thanks!
Closes #7088