feat(forge bind): add option to skip json derives #7233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reptarrat
requested review from
DaniPopes,
Evalir and
mattsse
as code owners
reptarrat
force-pushed
the
update-ethers-abigen-fix
branch
from
080f974
to
3d6b7d4
Compare
mattsse
approved these changes
Feb 26, 2024
zeroXbrock
pushed a commit
to flashbots/suavex-foundry
that referenced
this pull request
Apr 2, 2024
* chore: bump ethers deps * feat(forge bind): add option to skip json derives --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #7181
Additionally, I ran into issues with the serde derives because they also are not compatible with
[T; >32].Solution
To address #7181, this PR updates ethers deps to include fix from gakonst/ethers-rs#2743.
To address the issue with the serde derives, this PR adds a flag
--skip-extra-derives, which skips adding the serde derives and the serde dep to the generated crate. Not sure if this is the best fix since it 1) extends the api forbind2) might be better to fix the issue in the abigen logicI manually verified that
forge bindnow generates valid rust bindings for the solidity source code mentioned in #7181