Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cast): correctly compute mapping indexes #7261

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix(cast): correctly compute mapping indexes #7261

merged 2 commits into from
Feb 28, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Feb 28, 2024 •
edited
Loading

Fixes #6692

mattsse
mattsse approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks champ!

@mattsse mattsse added the C-cast Command: cast label Feb 28, 2024
@DaniPopes DaniPopes merged commit 6af18e4 into master Feb 28, 2024
19 checks passed
@DaniPopes DaniPopes deleted the dani/fix-cast-index branch February 28, 2024 13:37
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
C-cast Command: cast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cast index string does not work
2 participants
@DaniPopes @mattsse