-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(invariants
): real-time runs counter
#7302
feat(invariants
): real-time runs counter
#7302
Conversation
just noticed #3607 I think the approach of global invariant reporter could be a good foundation of adding such, wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a very nice UX improvement, ty
pending @DaniPopes @klkvr
Have you tested this in the context of multiple other unit and fuzz tests? It looks like it will constantly get "overwritten" by the other test results that stream in, so I don't think this is right. This is something I've thought about before, and I think I'll post a proposal as an issue soon and we'll discuss this internally soon. Also I would prefer you follow conventional commits, at least for PR names 😸 (instead of |
yep, I tested it, it is basically following the flow of results, see below
TIL, will do! |
invariants
): real-time runs counter
Yeah you can see the spinner gets interleaved with the other results, I'd prefer we hold off on this for now. That's a much better title, thanks! |
retired in favor of #7914 |
Motivation
proposed way to handle #585
Solution
show_progress
option is set to true (or run with env varFOUNDRY_INVARIANT_SHOW_PROGRESS=true forge test
)