fix(forge): do not re-execute script on resume when possible #7361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/avoid-reexecute-on-resume
branch
from
ac08278 to
accb3b0
Compare
klkvr
force-pushed
the
klkvr/avoid-reexecute-on-resume
branch
2 times, most recently
from
1329761 to
ee7ab32
Compare
klkvr
force-pushed
the
klkvr/avoid-reexecute-on-resume
branch
from
ee7ab32 to
d2c045c
Compare
onbjerg
approved these changes
Mar 12, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now resuming a script requires re-executing it which is expensive and not always possible (i.e. when some transactions already landed and altered state)
We only need to re-execute it if there are any private keys which appeared first time during execution,
Solution
Move
resumelogic toCompiledStateand only execute script if we are missing any signers fromtx.froms.This brings back
--multiflag requirement when resuming multi-chain script