Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci #7363

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fix: ci #7363

Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions crates/forge/bin/cmd/test/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,12 @@ impl TestArgs {
// Set up trace identifiers.
let known_contracts = runner.known_contracts.clone();
let remote_chain_id = runner.evm_opts.get_remote_chain_id();
let mut identifier = TraceIdentifiers::new()
.with_local(&known_contracts)
.with_etherscan(&config, remote_chain_id)?;
let mut identifier = TraceIdentifiers::new().with_local(&known_contracts);

// Avoid using etherscan for gas report as we decode more traces and this will be expensive.
if !self.gas_report {
identifier = identifier.with_etherscan(&config, remote_chain_id)?;
}

// Run tests.
let (tx, rx) = channel::<(String, SuiteResult)>();
Expand Down Expand Up @@ -424,12 +427,12 @@ impl TestArgs {
// setUp and constructor.
for (kind, arena) in &result.traces {
if !matches!(kind, TraceKind::Execution) {
decoder.identify(arena, &mut local_identifier);
decoder.identify(arena, &mut identifier);
}
}

for arena in trace {
decoder.identify(arena, &mut local_identifier);
decoder.identify(arena, &mut identifier);
gas_report.analyze([arena], &decoder).await;
}
}
Expand Down
Loading