Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor tests layout #7410

Merged
merged 11 commits into from
Mar 20, 2024
Merged

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Mar 15, 2024

Motivation

Refactors tesdata durectory to separate default tests from cancun and potentially more directories.

Solution

Introduces ForgeTestProfile which manages configuration and layout of the test project.

@klkvr klkvr marked this pull request as draft March 15, 2024 15:08
@klkvr klkvr marked this pull request as ready for review March 16, 2024 22:58
@klkvr klkvr changed the title [wip] chore: refactor tests layout chore: refactor tests layout Mar 16, 2024
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome,

I believe this is exactly what we need, and unlocks the blobfee/cancun related cheatcodes

mind taking a look at this @onbjerg ?

Comment on lines 187 to 188

pub static TEST_DATA_DEFAULT: Lazy<ForgeTestData> =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs needs a few more docs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, the profile approach should be flexible to account for any additional future changes.

I'd like to see a few more docs on the new types

@klkvr klkvr requested a review from mattsse March 17, 2024 21:39
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should work

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/forge/tests/it/config.rs Outdated Show resolved Hide resolved
@klkvr klkvr requested a review from DaniPopes March 19, 2024 22:11
@klkvr klkvr merged commit 319398f into foundry-rs:master Mar 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants