-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor tests layout #7410
Conversation
6480794
to
fdcae85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome,
I believe this is exactly what we need, and unlocks the blobfee/cancun related cheatcodes
mind taking a look at this @onbjerg ?
|
||
pub static TEST_DATA_DEFAULT: Lazy<ForgeTestData> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs needs a few more docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, the profile approach should be flexible to account for any additional future changes.
I'd like to see a few more docs on the new types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation
Refactors tesdata durectory to separate
default
tests fromcancun
and potentially more directories.Solution
Introduces
ForgeTestProfile
which manages configuration and layout of the test project.