Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(evm): remove trace printer, trim inspector stack #7437

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

DaniPopes
Copy link
Member

I don't think this has much use, and is only exposed in cast run.
Additionally, trim inspector stack implementation when the internal inspector does nothing

@DaniPopes DaniPopes requested a review from mattsse as a code owner March 19, 2024 04:38
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree w this but would want another review because i lost original context on why this was even added

@onbjerg onbjerg added the T-debt Type: code debt label Mar 19, 2024
@DaniPopes DaniPopes requested a review from klkvr March 19, 2024 17:02
Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, --trace-printer output is barely readable, we have cast run --debug so it should be fine

@DaniPopes DaniPopes merged commit 03b60c9 into master Mar 19, 2024
19 checks passed
@DaniPopes DaniPopes deleted the dani/rm-evm-printer branch March 19, 2024 22:43
@drortirosh
Copy link

Why was it removed?

It provides a low-level tracing information even on blockchains that doesn't support debug_trace APIs, which is great.

An example of an issue I currently try to handle (and had to recompile an old cast for it)
We try to assess the cost of "post-verkle" of contracts.
To do so, we need a trace of all opcodes executed (e.g. a sequence of [address,PC])
We then calculate the code "slots" accessed.
But as I said, this can't be done without this tracing capability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-debt Type: code debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants