feat(anvil): remove all txs from tx pool by sender origin #7480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Mar 24, 2024
crates/anvil/src/eth/pool/mod.rs
Outdated
Comment on lines
354
to
364
| self.pending_transactions.transactions_by_sender(sender).map(|tx| tx.hash()).collect(); | ||
| tx_hashes.extend( | ||
| self.ready_transactions | ||
| .transactions_by_sender(sender) | ||
| .map(|tx| tx.hash()) | ||
| .collect::<Vec<TxHash>>(), | ||
| ); | ||
|
|
||
| if tx_hashes.is_empty() { | ||
| return vec![] | ||
| } |
There was a problem hiding this comment.
can we extract this to a transactions_by_sender that merges those?
There was a problem hiding this comment.
Refactored! Let me know if this is what you meant!
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context: #7250
Solution
Adds
anvil_removePoolTransactionsmethod that removes pool transactions by sender origin.