Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(verify): multichain verification for etherscan #7537

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

yash-atreya
Copy link
Member

Motivation

Closes #7485

Solution

Incorporate the chain_id parameter while building etherscan client

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! pending errors

@yash-atreya
Copy link
Member Author

@mattsse Failing cargo deny due to open-ssl being banned. This occurs after updating to reqwest@0.12.2 and enabling the default-tls feature on it to use it here:

https://github.com/yash-atreya/foundry/blob/f686351921f0d666fa726b8420aa27d312c0e0d8/crates/config/src/etherscan.rs#L323

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no openssl

crates/config/Cargo.toml Outdated Show resolved Hide resolved
@yash-atreya yash-atreya requested a review from mattsse April 2, 2024 14:45
@mattsse mattsse merged commit dbc48ea into foundry-rs:master Apr 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Etherscan Multichain Contract Verification
2 participants