Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(invariant): honor targetContract setting, don't update targets if any #7595

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Apr 8, 2024

Motivation

Closes #5625
slightly different approach than proposed in #6200

Solution

  • add is_updatable flag in FuzzRunIdentifiedContracts, false if there's any contract marked as targetContract
  • record new contracts created only if is_updatable
  • tests for both cases, some code cleanup

follow up: document targetInterfaces usage

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but I'd like some more eyes on it @mattsse @klkvr
Pending also conflicts

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good re: code, but would like @mds1 to test this out

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

targeted_contracts in invariant test is getting updated unexpectedly partway through an invariant test run
4 participants