Anvil tests alloy migration #7619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce_transaction`, `can_reject_too_high_gas_limits`, `can_reject_underpriced_replacement`
zerosnacks
reviewed
Apr 11, 2024
Comment on lines
+31
to
+69
| pub fn http_provider(http_endpoint: &str) -> AlloyRetryProvider { | ||
| get_http_provider(http_endpoint) | ||
| } | ||
|
|
||
| pub fn http_provider_with_signer( | ||
| http_endpoint: &str, | ||
| signer: EthereumSigner, | ||
| ) -> RetryProviderWithSigner { | ||
| AlloyProviderBuilder::new(http_endpoint) | ||
| .build_with_signer(signer) | ||
| .expect("failed to build Alloy HTTP provider with signer") | ||
| } | ||
|
|
||
| pub fn ws_provider(ws_endpoint: &str) -> AlloyRetryProvider { | ||
| AlloyProviderBuilder::new(ws_endpoint).build().expect("failed to build Alloy WS provider") | ||
| } | ||
|
|
||
| pub fn ws_provider_with_signer( | ||
| ws_endpoint: &str, | ||
| signer: EthereumSigner, | ||
| ) -> RetryProviderWithSigner { | ||
| AlloyProviderBuilder::new(ws_endpoint) | ||
| .build_with_signer(signer) | ||
| .expect("failed to build Alloy WS provider with signer") | ||
| } | ||
|
|
||
| pub async fn ipc_provider(ipc_endpoint: &str) -> AlloyRetryProvider { | ||
| AlloyProviderBuilder::new(ipc_endpoint).build().expect("failed to build Alloy IPC provider") | ||
| } | ||
|
|
||
| pub async fn ipc_provider_with_signer( | ||
| ipc_endpoint: &str, | ||
| signer: EthereumSigner, | ||
| ) -> RetryProviderWithSigner { | ||
| AlloyProviderBuilder::new(ipc_endpoint) | ||
| .build_with_signer(signer) | ||
| .expect("failed to build Alloy IPC provider with signer") | ||
| } | ||
|
|
There was a problem hiding this comment.
We probably will want to include the recommended layers in try_get_http_provider at some point
…_manually` tx tests migrated to alloy
…toric` tx tests to alloy
…e_nonce & can_handle_multiple_concurrent_transactions_with_same_nonce tx tests
|
@mattsse Facing an issue with error: ErrorPayload { code: -32602, message: "invalid type: boolean `true`, expected
// unit", data: None }I'll take |
zerosnacks
changed the base branch from
master
to
zerosnacks/port-anvil-to-alloy
mattsse
pushed a commit
to paradigmxyz/revm-inspectors
that referenced
this pull request
Apr 17, 2024
## Motivation Alloy deps need to be bumped in foundry-rs/foundry#7619. This creates a conflicting deps version between `evm-inspectors` and `foundry` for `alloy-rpc-types` and `alloy-rpc-types-trace` ## Solution Bump to latest alloy commit
zerosnacks
reviewed
Apr 17, 2024
| @@ -202,11 +202,11 @@ where | |||
| fn get_account_req(&self, address: Address) -> ProviderRequest<eyre::Report> { | |||
| trace!(target: "backendhandler", "preparing account request, address={:?}", address); | |||
| let provider = self.provider.clone(); | |||
| let block_id = self.block_id; | |||
| let block_id = self.block_id.unwrap_or(BlockId::latest()); | |||
There was a problem hiding this comment.
I think you could use unwrap_or_default() here as it will use BlockId::latest() by default, same goes for the other instances
zerosnacks
reviewed
Apr 17, 2024
23 tasks
|
Superceded by #7701 to collaborate easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove the last bit of
ethersdependency.Solution
WIP
Replace with
alloy.