Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debugger): update ratatui, use List #7676

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Apr 15, 2024

Update ratatui from 0.24 to 0.26, the only observable breaking change is Layout builder method params were moved to the new method.

Use builtin List widget to handle printing opcodes. This fixes a bunch of logic errors with that code that nobody wants to debug by removing it.
Differences:

  • the highlight symbol is before the index instead of the opcode name
  • 1 opcode padding instead of whatever that code did, meaning the highlight will stop 1 before the end
    • this would just go off screen if the box was too small
  • the highlight spans across the entire box rather than just behind the text

Some other misc fixes:

  • generate the opcode list after the event has been handled. Fixes a small bug when changing call context as the opcode list would be the wrong one until another event was handled
  • clamp repeat number (e.g. 1000k) to 1..=100_000
  • sync mouse wheel step and keyboard step logic
  • don't reset memory view when stepping

Before

Peek 2024-04-16 00-57

After

Peek 2024-04-16 00-56

@mattsse mattsse requested a review from klkvr April 15, 2024 23:22
@DaniPopes DaniPopes merged commit 9207b93 into master Apr 16, 2024
20 checks passed
@DaniPopes DaniPopes deleted the dani/update-debugger branch April 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants