feat(forge-cli): Add --no-metadata as CLI compiler option
#7684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bor_metadata = false`
…, bytecode_hash to none
DaniPopes
reviewed
Apr 16, 2024
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
mattsse
approved these changes
Apr 16, 2024
zerosnacks
deleted the
zerosnacks/add-disable-metadata-to-forge-build-cli
branch
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7488
Adds
--no-metadataas CLI option, equivalent to passing--no-cbor-metadata --metadata-hash nonetosolcor defining:in
foundry.toml.Solution
Considering the requirement for deterministic builds is common I think it makes sense to add a CLI option that bundles the two as requested.
For comparison between
forge buildandforge build --no-metadata: https://jsoncompare.com/#!/diff/id=f0200fd7445202aefdf057a353664f29/Open to feedback, it may make more sense to decouple the two, contrary to the proposal, and allow users to pass
--no-cbor-metadata --bytecode-hash="none".