fix(cheatcodes): expectSafeMemory + stopExpectSafeMemory
#7686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
requested review from
DaniPopes,
mattsse,
klkvr and
Evalir
as code owners
clabby
changed the title
expectSafeMemory w/ new forge-stdexpectSafeMemory + stopExpectSafeMemory
Fixes the `stopExpectSafeMemory` by allowing for the memory allocation of the `stopExpectSafeMemory` selector as well as the potentially out-of-bounds read performed in the `CALL` operation. Currently, forge reports incorrectly that memory safety was violated in a memory safe region of a test, if the free memory pointer was updated to `[exclusiveUpperBound-31, exclusiveUpperBound]`. To fix this, we allow for `MSTORE` operations that store the selector bytes for `stopExpectSafeMemory` outside of the allowed region, as well as `CALL` operations that are to the cheatcode address and contain the `stopExpectSafeMemory` selector in the first 4 bytes of the call arguments.
clabby
force-pushed
the
cl/fix-expect-safe-mem
branch
from
e29393d to
d346ea9
Compare
DaniPopes
approved these changes
Apr 16, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the
stopExpectSafeMemorycheatcode by allowing for the memory allocation of thestopExpectSafeMemoryselector as well as the potentially out-of-bounds read performed in theCALLoperation to the cheatcode contract.Currently, forge reports incorrectly that memory safety was violated in a memory safe region of a test, if the free memory pointer was updated to
[exclusiveUpperBound-31, exclusiveUpperBound]during execution and is followed by astopExpectSafeMemorycall.To fix this, we allow for
MSTOREoperations that store the selector bytes forstopExpectSafeMemory, as well asCALLoperations that are to the cheatcode address and contain thestopExpectSafeMemoryselector in the first 4 bytes of the call arguments, even if they write/read from outside of the allowed region(s).