fix(forge): fix forge clone when there is nested src
#7747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhangZhuoSJTU
requested review from
DaniPopes,
Evalir and
mattsse
as code owners
|
More local tests may be needed before merging it. |
…obustness if necessary test: add two more tests for forge clone
|
I think the referenced bug has been properly fixed. @mattsse |
DaniPopes
reviewed
Apr 22, 2024
DaniPopes
approved these changes
Apr 22, 2024
mattsse
approved these changes
Apr 22, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7736