Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate: cast doctests to alloy #7768

Merged
merged 4 commits into from
Apr 23, 2024
Merged

migrate: cast doctests to alloy #7768

merged 4 commits into from
Apr 23, 2024

Conversation

yash-atreya
Copy link
Member

Motivation

Remove ethers from codebase

Solution

Migrate to alloy

@yash-atreya yash-atreya self-assigned this Apr 23, 2024
@yash-atreya yash-atreya marked this pull request as ready for review April 23, 2024 20:01
onbjerg
onbjerg approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nits lgtm otherwise

crates/cast/src/lib.rs Outdated Show resolved Hide resolved
crates/cast/src/lib.rs Outdated Show resolved Hide resolved
crates/cast/src/lib.rs Outdated Show resolved Hide resolved
@onbjerg onbjerg added A-docs Area: docs T-debt Type: code debt labels Apr 23, 2024
mattsse
mattsse requested changes Apr 23, 2024
View reviewed changes
crates/cast/src/lib.rs Outdated Show resolved Hide resolved
crates/cast/src/lib.rs Outdated Show resolved Hide resolved
@yash-atreya yash-atreya requested review from mattsse and onbjerg April 23, 2024 21:28
@onbjerg onbjerg merged commit e0ea59c into foundry-rs:master Apr 23, 2024
19 checks passed
@0xgregthedev 0xgregthedev mentioned this pull request Apr 26, 2024
Merged
ArkFunds

This comment was marked as spam.

Sign in to view

ArkFunds

This comment was marked as spam.

Sign in to view

@0xgregthedev 0xgregthedev mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArkFunds ArkFunds ArkFunds approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees

@yash-atreya yash-atreya

Labels
A-docs Area: docs T-debt Type: code debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yash-atreya @onbjerg @mattsse @DaniPopes @ArkFunds